Marc St-Jean wrote:
Jeff Garzik wrote:
Marc St-Jean wrote:
> + res = platform_get_resource(pldev, IORESOURCE_MEM, 0);
> + if (!res) {
> + printk(KERN_ERR "MSPETH(probe) %s: "
> + "IOMEM resource not found for eth%d\n",
> + dev->nam
St-Jean wrote:
> > [PATCH 10/12] drivers: PMC MSP71xx ethernet driver
> >
> > Patch to add an ethernet driver for the PMC-Sierra MSP71xx devices.
> >
> > Patches 1 through 9 were posted to [EMAIL PROTECTED] as well
> > as other sub-system lists/maintainers as appropri
Jeff Garzik wrote:
> Marc St-Jean wrote:
> > I asked if the remaining section (above) was acceptable so we could
> retain our
> > buffer recycling which enhances throughput. I never received a rely
> so it was
> > left in my last patch.
> >
> > The above comment now answers my part of my in
Marc St-Jean wrote:
I asked if the remaining section (above) was acceptable so we could retain our
buffer recycling which enhances throughput. I never received a rely so it was
left in my last patch.
The above comment now answers my part of my initial question. Are you aware of
a better way to i
Jeff Garzik wrote:
> Marc St-Jean wrote:
> > +inline static void
> > +mspeth_skb_headerinit(struct sk_buff *skb)
> > +{
> > + /* these are essential before init */
> > + dst_release(skb->dst);
> > +#ifdef CONFIG_XFRM
> > + secpath_put(skb->sp);
> > +#endif
> > +#ifdef CONFIG_NE
Marc St-Jean wrote:
+inline static void
+mspeth_skb_headerinit(struct sk_buff *skb)
+{
+ /* these are essential before init */
+ dst_release(skb->dst);
+#ifdef CONFIG_XFRM
+ secpath_put(skb->sp);
+#endif
+#ifdef CONFIG_NETFILTER
+ nf_conntrack_put(skb->nfct);
+#if defined(
Thanks for the feedback Jeff. I have made all modifications but I have one
question regarding the SKB recycling.
Removing the backwards compatibility for the linux 2.4 eliminated the
badness in mspeth_skb_headerinit(). However there is still some SKB code
in mspeth_alloc_skb(). You didn't specific
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#elif LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
+#include
+#include
+#include
+#include
+#include
+#include
+#endif /* LINUX_VERSION_CODE */
+
+#include
