Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-14 Thread kbuild test robot
Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc8 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commi

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-12 Thread Andrew Lunn
> > It actually has nothing to do with PHY to PHY connections. You can > > use > > pause frames with direct MAC to MAC connections. PHY auto-negotiation > > is one way to indicate both ends support it, but there are also other > > ways. e.g. > > > > ethtool -A|--pause devname [autoneg on|off] [rx

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-12 Thread Robert Beckett
On Thu, 2019-09-12 at 00:52 +0200, Andrew Lunn wrote: > > It is not just for broadcast storm protection. The original issue > > that > > made me look in to all of this turned out to be rx descritor ring > > buffer exhaustion due to the CPU not being able to keep up with > > packet > > reception. >

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Andrew Lunn
> It is not just for broadcast storm protection. The original issue that > made me look in to all of this turned out to be rx descritor ring > buffer exhaustion due to the CPU not being able to keep up with packet > reception. Pause frames does not really solve this problem. The switch will at som

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread kbuild test robot
Hi Robert, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc8 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rob

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Wed, 2019-09-11 at 10:16 +0100, Robert Beckett wrote: > On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > > This enables us to negoatiate pause frame transmission to >

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > This enables us to negoatiate pause frame transmission to > > > prioritise > > > packet delivery over throughput. > > > > I

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Florian Fainelli
On 9/10/19 11:26 AM, Andrew Lunn wrote: > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: >> This enables us to negoatiate pause frame transmission to prioritise >> packet delivery over throughput. > > I don't think we can unconditionally enable this. It is a big > behaviour change

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Andrew Lunn
On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > This enables us to negoatiate pause frame transmission to prioritise > packet delivery over throughput. I don't think we can unconditionally enable this. It is a big behaviour change, and it is likely to break running systems. It ha

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Florian Fainelli
On 9/10/19 8:41 AM, Robert Beckett wrote: > Configure autoneg for phy connected CPU ports. > This allows us to use autoneg between the CPU port's phy and the link > partner's phy. > This enables us to negoatiate pause frame transmission to prioritise > packet delivery over throughput. s/autoneg/au

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:47 +0100, Robert Beckett wrote: > Configure autoneg for phy connected CPU ports. > This allows us to use autoneg between the CPU port's phy and the link > partner's phy. > This enables us to negoatiate pause frame transmission to prioritise > packet delivery

[PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Robert Beckett
Configure autoneg for phy connected CPU ports. This allows us to use autoneg between the CPU port's phy and the link partner's phy. This enables us to negoatiate pause frame transmission to prioritise packet delivery over throughput. Signed-off-by: Robert Beckett --- net/dsa/port.c | 10