Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-08 Thread Stefano Garzarella
On Sun, Jan 03, 2021 at 10:57:50PM +0300, Arseny Krasnov wrote: This extends rx loop for SOCK_SEQPACKET packets and implements callback which user calls to copy data to its buffer. Please write a better commit message explaining the changes, e.g. that you are using 'flags' to transport

Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-06 Thread Arseny Krasnov
> IMHO you can avoid this special-casing > by introducing yet another outer loop just > for draining the extra data from buffer. > Admittedly that may also require an extra > transport op. I'm not sure that extra tranport op is needed, may be i'll try to put drain code inside copy loop, because on

Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-03 Thread kernel test robot
Hi Arseny, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc1 next-20201223] [cannot apply to vhost/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-03 Thread stsp
03.01.2021 22:57, Arseny Krasnov пишет: This extends rx loop for SOCK_SEQPACKET packets and implements callback which user calls to copy data to its buffer. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h| 7 + include/net/af_vsock.h |

[PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-03 Thread Arseny Krasnov
This extends rx loop for SOCK_SEQPACKET packets and implements callback which user calls to copy data to its buffer. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h| 7 + include/net/af_vsock.h | 4 + include/uapi/linux/virtio_vsock.h