Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2007 13:30:28 +0200, Stefan Richter <[EMAIL PROTECTED]> wrote: > So, since figuring the correct DMA device out is done by drivers > themselves, they usually can figure out the correct NUMA node as well. > The only precondition is that each DMA device has the correct NUMA node > set.

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Stefan Richter
Cornelia Huck wrote: > On Thu, 12 Jul 2007 07:47:52 +0200, > Stefan Richter <[EMAIL PROTECTED]> wrote: >> Also keep in mind that either device_move() should update the numa_node, >> or the subsystems which call device_move() should explicitly update it >> on their own. (Unless they know that thei

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2007 07:47:52 +0200, Stefan Richter <[EMAIL PROTECTED]> wrote: > The patch does nothing for all subsystems which do > > device_initialize(&dev); > dev->parent = pd; > device_add(&dev); > > Let's avoid to add infrastructure which does nothing, or only does > somet

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: > Stefan Richter wrote: >> Yinghai Lu wrote: >>> original default is -1, and this patch just try to use parent's node as >>> default. >> >> But in many cases, the patch does so at a time when the parent is not >> yet known. > then it will use -1. Yes. The patch does nothing for

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Yinghai Lu
Stefan Richter wrote: Yinghai Lu wrote: original default is -1, and this patch just try to use parent's node as default. But in many cases, the patch does so at a time when the parent is not yet known. then it will use -1. YH - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: > original default is -1, and this patch just try to use parent's node as > default. But in many cases, the patch does so at a time when the parent is not yet known. -- Stefan Richter -=-=-=== -=== -==-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Yinghai Lu
Greg KH wrote: On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: Yinghai Lu wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) void device_initialize(struct device *dev) { + int node; +

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Greg KH
On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: > Yinghai Lu wrote: > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) > > > > void device_initialize(struct device *dev) > > { > > + int node;

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
I wrote: > - device_move() should update the device.node. device.numa_node of course. -- Stefan Richter -=-=-=== -=== -=-== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) > > void device_initialize(struct device *dev) > { > + int node; > + > kobj_set_kset_s(dev, devices_subsys); > kobject_init(&dev->

[PATCH 1/5] try parent numa_node at first before using default

2007-07-10 Thread Yinghai Lu
[PATCH 1/5] try parent numa_node at first before using default For pci_device, pcibios_scan_root and pci_scan_root will call pci_device_add. pci_device_add will call device_initialize and set_dev_node(&dev->dev, pcibus_to_node(bus)). other device such as netdev, and usb_device, set_dev_