Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-26 Thread Franklin S Cooper Jr
Hi Kurt, On 07/26/2017 03:04 PM, Kurt Van Dijck wrote: > Hi, > > I know my response is late ... > >> Hi Oliver >> On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: >>> Hi Franklin, >>> >>> On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: >>> +#ifdef CONFIG_OF +void of_transceiver_is_fi

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-26 Thread Kurt Van Dijck
Hi, I know my response is late ... > Hi Oliver > On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: > > Hi Franklin, > > > > On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > > > >> +#ifdef CONFIG_OF > >> +void of_transceiver_is_fixed(struct net_device *dev) > >> +{ > > > > (..) > > > >> +} >

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Franklin S Cooper Jr
On 07/20/2017 04:52 AM, Sergei Shtylyov wrote: > Hello! > > On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: > >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is connected to. This can lead to >> unexpected errors. However, CAN transcei

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Franklin S Cooper Jr
Hi Oliver On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: > Hi Franklin, > > On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > >> +#ifdef CONFIG_OF >> +void of_transceiver_is_fixed(struct net_device *dev) >> +{ > > (..) > >> +} >> +EXPORT_SYMBOL(of_transceiver_is_fixed); >> +#endif > > I'm

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Sergei Shtylyov
Hello! On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to di

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Oliver Hartkopp
Hi Franklin, On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: +#ifdef CONFIG_OF +void of_transceiver_is_fixed(struct net_device *dev) +{ (..) +} +EXPORT_SYMBOL(of_transceiver_is_fixed); +#endif I'm not sure about the naming here. As this is a CAN transceiver related option it should b

[PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-19 Thread Franklin S Cooper Jr
Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to discover these limitations at runtime. Therefore, add support f