Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-19 Thread Leon Romanovsky
On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: > >so, I continue to have it. > > I will continue to bash on your odd codingstyle. Please fix it! Jiri, Checkpatch errors is an easiest issue with this patch. It is full of functions without use, unconnected macros and if you replace "

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-19 Thread oulijun
On 2016/3/17 14:43, Leon Romanovsky wrote: > On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: >>> so, I continue to have it. >> >> I will continue to bash on your odd codingstyle. Please fix it! > > Jiri, > > Checkpatch errors is an easiest issue with this patch. > > It is full of fun

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread Jiri Pirko
Wed, Mar 16, 2016 at 11:23:10AM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks your reviewing. >sorry, I will send a new patch according to your reviews. > >On 2016/3/11 18:42, Jiri Pirko wrote: >> Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >>> The driver for Hisilicon Ro

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi dledford, thanks for reviewing. I have modified according to your reivews. I will send a new patch at soon. thanks Lijun Ou On 2016/3/12 18:39, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The driv

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread oulijun
Hi Jiri Pirko, thanks your reviewing. sorry, I will send a new patch according to your reviews. On 2016/3/11 18:42, Jiri Pirko wrote: > Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >> The driver for Hisilicon RoCE is a platform driver. >> The driver will support mulitple versions

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-12 Thread Leon Romanovsky
On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: > The driver for Hisilicon RoCE is a platform driver. > The driver will support mulitple versions of hardware. Currently only "v1" > for hip06 SOC is supported. > The driver includes two parts: common driver and hardware-specific > operation

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-11 Thread Jiri Pirko
Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >The driver for Hisilicon RoCE is a platform driver. >The driver will support mulitple versions of hardware. Currently only "v1" >for hip06 SOC is supported. >The driver includes two parts: common driver and hardware-specific >operation