Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Simon Horman
On Mon, Oct 21, 2019 at 09:09:44AM +0100, Russell King - ARM Linux admin wrote: > On Mon, Oct 21, 2019 at 09:40:31AM +0200, Simon Horman wrote: > > On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > > > From: Russell King > > > > > > A bitrate of 255 is special, it means the bitrate

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Russell King - ARM Linux admin
On Mon, Oct 21, 2019 at 09:40:31AM +0200, Simon Horman wrote: > On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > > From: Russell King > > > > A bitrate of 255 is special, it means the bitrate is encoded in > > byte 66 in units of 250MBaud. Add support for parsing these bit > > rat

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Simon Horman
On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > From: Russell King > > A bitrate of 255 is special, it means the bitrate is encoded in > byte 66 in units of 250MBaud. Add support for parsing these bit > rates. Hi Russell, it seems from the code either that 0 is also special or

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-19 Thread Andrew Lunn
On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > From: Russell King > > A bitrate of 255 is special, it means the bitrate is encoded in > byte 66 in units of 250MBaud. Add support for parsing these bit > rates. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andr

[PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-18 Thread Russell King
From: Russell King A bitrate of 255 is special, it means the bitrate is encoded in byte 66 in units of 250MBaud. Add support for parsing these bit rates. Signed-off-by: Russell King --- sfpid.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/sfpid.c b/