Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-28 Thread Randy Dunlap
Wagner Ferenc wrote: Randy Dunlap <[EMAIL PROTECTED]> writes: On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote: Patches 1 & 3 use if (res) statement; but the preferred form is if (res) statement; Even if this style was already used in

Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-28 Thread Wagner Ferenc
Randy Dunlap <[EMAIL PROTECTED]> writes: > On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote: > > Patches 1 & 3 use > > if (res) statement; > > but the preferred form is > > if (res) > statement; > > Even if this style was already used in the source

Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-27 Thread Randy Dunlap
On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote: > Also remove trailing spaces from multivalued files. > > This fixes output like for example: > > $ od -c /sys/class/net/bond0/bonding/slaves > 000 e t h - l e f t e t h - r i g > 0

[PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-27 Thread =?utf-8?q?Ferenc_W=C3=A1gner?=
Also remove trailing spaces from multivalued files. This fixes output like for example: $ od -c /sys/class/net/bond0/bonding/slaves 000 e t h - l e f t e t h - r i g 020 h t \n \0 025 It mostly entails deleting '+1'-s after sprintf() calls: