Re: [PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups

2020-08-02 Thread Andrew Lunn
> Did you apply patch 2/2 of the patchset? > Because version-printing (and the need for a version string) was removed > from lib8390.c in patch 2/2 to allow the replacement of said > version-string with MODULE_* macros in 8390.c, and failing to do so whould > result > in the exact same error. Hi

Re: [PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups

2020-08-02 Thread Armin Wolf
On Sat, Aug 01, 2020 at 09:32:04PM -0700, Jakub Kicinski wrote: > On Sat, 1 Aug 2020 22:52:42 +0200 Armin Wolf wrote: > > Replace version string with MODULE_* macros. > > > > Include necessary libraries. > > > > Fix two minor coding-style issues. > > > > Signed-off-by: Armin Wolf > > This doesn't

Re: [PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups

2020-08-01 Thread Jakub Kicinski
On Sat, 1 Aug 2020 22:52:42 +0200 Armin Wolf wrote: > Replace version string with MODULE_* macros. > > Include necessary libraries. > > Fix two minor coding-style issues. > > Signed-off-by: Armin Wolf This doesn't build but also ../drivers/net/ethernet/8390/lib8390.c:973:17: error: undefined

[PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups

2020-08-01 Thread Armin Wolf
Replace version string with MODULE_* macros. Include necessary libraries. Fix two minor coding-style issues. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/8390.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/8390/8