Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-06-04 Thread David Miller
From: Dan Carpenter Date: Thu, 31 May 2018 15:01:25 +0300 > @@ -380,7 +380,8 @@ static rx_handler_result_t > net_failover_handle_frame(struct sk_buff **pskb) > > static void net_failover_compute_features(struct net_device *dev) > { > - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F

Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-05-31 Thread Samudrala, Sridhar
On 5/31/2018 5:01 AM, Dan Carpenter wrote: This has an '&' vs '|' typo so it starts with vlan_features set to none. Also a u32 type isn't large enough to hold all the feature bits, it should be netdev_features_t. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan Car

[PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-05-31 Thread Dan Carpenter
This has an '&' vs '|' typo so it starts with vlan_features set to none. Also a u32 type isn't large enough to hold all the feature bits, it should be netdev_features_t. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan Carpenter diff --git a/drivers/net/net_failover.