Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Edgecombe, Rick P
On Thu, 2018-12-06 at 15:08 -0800, Nadav Amit wrote: > > On Dec 6, 2018, at 12:17 PM, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: > > > > On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > > > > > > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wro

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Nadav Amit
> On Dec 6, 2018, at 12:17 PM, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: >>> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: >>> >>> On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrot

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 12:20 PM Edgecombe, Rick P wrote: > > On Thu, 2018-12-06 at 11:19 -0800, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > > > > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > > > If we are going to unmap the line

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Edgecombe, Rick P
On Thu, 2018-12-06 at 11:19 -0800, Andy Lutomirski wrote: > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > > If we are going to unmap the linear alias, why not do it at vmalloc() > > > > time rather than vfree()

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: > > > On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > >> On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > If we are going to unmap the linear alias, why no

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Nadav Amit
> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: >> On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: If we are going to unmap the linear alias, why not do it at vmalloc() time rather than vfree() time? >>>

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 20:30, Will Deacon wrote: > > On Thu, Dec 06, 2018 at 08:23:20PM +0100, Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > > > > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > > > wrote: > > > > > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lu

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Will Deacon
On Thu, Dec 06, 2018 at 08:23:20PM +0100, Ard Biesheuvel wrote: > On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > > wrote: > > > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > > > > > > > That’s not totally nuts. Do

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > wrote: > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > > work on module data? Perhaps crypt

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > work on module data? Perhaps crypto code trying to encrypt static > > data because our APIs don’t unders

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > If we are going to unmap the linear alias, why not do it at vmalloc() > > > time rather than vfree() time? > > > > That’s not totally nuts. Do we ever have code that exp

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > On Dec 5, 2018, at 11:29 PM, Ard Biesheuvel > > wrote: > > > >> On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: > >> > >>> On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > >>> > On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Tycho Andersen
On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > On Dec 5, 2018, at 11:29 PM, Ard Biesheuvel > > wrote: > > > >> On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: > >> > >>> On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > >>> > On Tue, Dec 04, 2018 at 12:09:49PM -

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
> On Dec 5, 2018, at 11:29 PM, Ard Biesheuvel wrote: > >> On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: >> >>> On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: >>> On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy Lutomirski wrote: On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Will Deacon
On Thu, Dec 06, 2018 at 08:29:03AM +0100, Ard Biesheuvel wrote: > On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: > > > > On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > > > > > > On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy Lutomirski wrote: > > > > On Tue, Dec 4, 2018 at 12:02 PM Edge

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-05 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: > > On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > > > > On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy Lutomirski wrote: > > > On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P > > > wrote: > > > > > > > > On Tue, 2018-12-04 at 16:03 +000

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-05 Thread Andy Lutomirski
On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > > On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy Lutomirski wrote: > > On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P > > wrote: > > > > > > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: > > > > On Mon, Dec 03, 2018 at 05:43:11PM -080

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-05 Thread Will Deacon
On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy Lutomirski wrote: > On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P > wrote: > > > > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: > > > On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: > > > > > On Nov 27, 2018, at 4:07 PM, Rick

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 5:45 PM, Edgecombe, Rick P > wrote: > > On Tue, 2018-12-04 at 16:53 -0800, Nadav Amit wrote: >>> On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P >>> wrote: >>> >>> On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote: > On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P <

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Andy Lutomirski
> On Dec 4, 2018, at 3:52 PM, Edgecombe, Rick P > wrote: > >> On Tue, 2018-12-04 at 12:09 -0800, Andy Lutomirski wrote: >> On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P >> wrote: >>> On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: On Mon, Dec 03, 2018 at 05:43:11PM -0800

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Edgecombe, Rick P
On Tue, 2018-12-04 at 16:53 -0800, Nadav Amit wrote: > > On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P > > wrote: > > > > On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote: > > > > On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P < > > > > rick.p.edgeco...@intel.com> > > > > wrote: > > > > > > >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 5:09 PM, Edgecombe, Rick P > wrote: > > On Tue, 2018-12-04 at 14:48 -0800, Nadav Amit wrote: >>> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote: >>> >>> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: > On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Edgecombe, Rick P
On Tue, 2018-12-04 at 14:48 -0800, Nadav Amit wrote: > > On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote: > > > > On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: > > > > On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: > > > > > > > > On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P > wrote: > > On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote: >>> On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P >>> wrote: >>> >>> On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote: > On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P < >>>

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Edgecombe, Rick P
On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote: > > On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P > > wrote: > > > > On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote: > > > > On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P < > > > > rick.p.edgeco...@intel.com> > > > > wrote: > > > > > > >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P > wrote: > > On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote: >>> On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P >>> wrote: >>> >>> On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Ami

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Edgecombe, Rick P
On Tue, 2018-12-04 at 12:09 -0800, Andy Lutomirski wrote: > On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P > wrote: > > > > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: > > > On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: > > > > > On Nov 27, 2018, at 4:07 PM, Rick Edgeco

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 3:27 PM, Andy Lutomirski wrote: > > > > > On Dec 4, 2018, at 2:48 PM, Nadav Amit wrote: > >>> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote: >>> >>> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: > On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Andy Lutomirski
On Dec 4, 2018, at 2:48 PM, Nadav Amit wrote: >> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote: >> >> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: >> On Nov

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote: > > On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: >>> On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: >>> >>> On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > wrote: >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P > wrote: > > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: >> On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: On Nov 27, 2018, at 4:07 PM, Rick Edgecombe wrote: Since vfree will lazily flush the TLB, but n

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P wrote: > > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: > > On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: > > > > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > > > > wrote: > > > > > > > > Since vfree will lazily flush the T

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Edgecombe, Rick P
On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote: > On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: > > > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > > > wrote: > > > > > > Since vfree will lazily flush the TLB, but not lazily free the underlying > > > pages, > > > it often leav

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote: > > > On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: > > > > On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: > >>> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > >>> wrote: > >>> > >>> Since vfree will lazily flush the TLB, but not lazily

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Nadav Amit
> On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote: > > On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: >>> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe >>> wrote: >>> >>> Since vfree will lazily flush the TLB, but not lazily free the underlying >>> pages, >>> it often leaves stale TLB ent

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Andy Lutomirski
On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote: > > > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > > wrote: > > > > Since vfree will lazily flush the TLB, but not lazily free the underlying > > pages, > > it often leaves stale TLB entries to freed pages that could get re-used. > > This is >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-04 Thread Will Deacon
On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote: > > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > > wrote: > > > > Since vfree will lazily flush the TLB, but not lazily free the underlying > > pages, > > it often leaves stale TLB entries to freed pages that could get re-used. > > T

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-03 Thread Nadav Amit
> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > wrote: > > Since vfree will lazily flush the TLB, but not lazily free the underlying > pages, > it often leaves stale TLB entries to freed pages that could get re-used. This > is > undesirable for cases where the memory being freed has special pe

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-03 Thread Edgecombe, Rick P
It looks like this new flag is in linux-next now. As I am reading it, these architectures have a module_alloc that uses some sort of executable flag and are not using the default module_alloc which is already covered, and so may need it plugged in: arm arm64 parisc s390 unicore32 Thanks, Rick On

[PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-11-27 Thread Rick Edgecombe
Since vfree will lazily flush the TLB, but not lazily free the underlying pages, it often leaves stale TLB entries to freed pages that could get re-used. This is undesirable for cases where the memory being freed has special permissions such as executable. Having callers flush the TLB after callin