Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 12:39:31PM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 29 Mar 2017 20:14:44 +0300 > > > Some drivers can't support all features in all configurations. At the > > moment we blindly set FEATURES_OK and later FAILED. Support this better > > by addin

Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 29 Mar 2017 20:14:44 +0300 > Some drivers can't support all features in all configurations. At the > moment we blindly set FEATURES_OK and later FAILED. Support this better > by adding a callback drivers can use to do some early checks. > > Signed-off-by:

Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 11:06:27AM +0200, Cornelia Huck wrote: > On Wed, 29 Mar 2017 20:14:44 +0300 > "Michael S. Tsirkin" wrote: > > > Some drivers can't support all features in all configurations. At the > > moment we blindly set FEATURES_OK and later FAILED. Support this better > > by adding

Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread Cornelia Huck
On Wed, 29 Mar 2017 20:14:44 +0300 "Michael S. Tsirkin" wrote: > Some drivers can't support all features in all configurations. At the > moment we blindly set FEATURES_OK and later FAILED. Support this better > by adding a callback drivers can use to do some early checks. Looks reasonable. Do

[PATCH 1/2] virtio: allow drivers to validate features

2017-03-29 Thread Michael S. Tsirkin
Some drivers can't support all features in all configurations. At the moment we blindly set FEATURES_OK and later FAILED. Support this better by adding a callback drivers can use to do some early checks. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio.c | 6 ++ include/linux/vi