Re: [PATCH 1/2] udp: fix gso_segs calculations

2019-10-01 Thread Josh Hunt
On 10/1/19 5:12 AM, Willem de Bruijn wrote: On Mon, Sep 30, 2019 at 7:51 PM Alexander Duyck wrote: On Mon, Sep 30, 2019 at 3:15 PM Josh Hunt wrote: Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload") added gso_segs calculation, but incorrectly got sizeo

Re: [PATCH 1/2] udp: fix gso_segs calculations

2019-10-01 Thread Josh Hunt
On 9/30/19 4:51 PM, Alexander Duyck wrote: On Mon, Sep 30, 2019 at 3:15 PM Josh Hunt wrote: Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload") added gso_segs calculation, but incorrectly got sizeof() the pointer and not the underlying data type. It also d

Re: [PATCH 1/2] udp: fix gso_segs calculations

2019-10-01 Thread Willem de Bruijn
On Mon, Sep 30, 2019 at 7:51 PM Alexander Duyck wrote: > > On Mon, Sep 30, 2019 at 3:15 PM Josh Hunt wrote: > > > > Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation > > offload") > > added gso_segs calculation, but incorrectly got sizeof() the pointer and > > not the u

Re: [PATCH 1/2] udp: fix gso_segs calculations

2019-09-30 Thread Alexander Duyck
On Mon, Sep 30, 2019 at 3:15 PM Josh Hunt wrote: > > Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation > offload") > added gso_segs calculation, but incorrectly got sizeof() the pointer and > not the underlying data type. It also does not account for v6 UDP GSO segs. > >

[PATCH 1/2] udp: fix gso_segs calculations

2019-09-30 Thread Josh Hunt
Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload") added gso_segs calculation, but incorrectly got sizeof() the pointer and not the underlying data type. It also does not account for v6 UDP GSO segs. Fixes: dfec0ee22c0a ("udp: Record gso_segs when supporting UDP