Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jesse Brandeburg
Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comments without explaining why/where t

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jakub Kicinski
On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > These are tested to be the latest as part of the tools/lib/bpf build. > > But you didn't mention why you're making these changes, and you're > removing a lot of comments without explaining why/where there might be > a replacement or

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jesse Brandeburg
Hi Ian, Ian Rogers wrote: > These are tested to be the latest as part of the tools/lib/bpf build. But you didn't mention why you're making these changes, and you're removing a lot of comments without explaining why/where there might be a replacement or why the comments are useless. I now see tha