Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 6:29 PM Willy Tarreau wrote: > > On Mon, Sep 14, 2020 at 06:16:40PM +0200, Sedat Dilek wrote: > > On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > > > > > Hi > > > > > > Is this patch being pushed to any branch? I don't see it deployed > > > anywhere (unless I'm miss

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Willy Tarreau
On Mon, Sep 14, 2020 at 06:16:40PM +0200, Sedat Dilek wrote: > On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > > > Hi > > > > Is this patch being pushed to any branch? I don't see it deployed anywhere > > (unless I'm missing something...). > > > > It's here: > > [1] > https://git.kernel.

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > Hi > > Is this patch being pushed to any branch? I don't see it deployed anywhere > (unless I'm missing something...). > It's here: [1] https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise > Be

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 01:10:18PM +, David Laight wrote: > From: Willy Tarreau > > Sent: 01 September 2020 07:43 > ... > > +/* > > + * Generate some initially weak seeding values to allow > > + * the prandom_u32() engine to be started. > > + */ > > +static int __init prandom_init_early(void) >

RE: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread David Laight
From: Willy Tarreau > Sent: 01 September 2020 07:43 ... > +/* > + * Generate some initially weak seeding values to allow > + * the prandom_u32() engine to be started. > + */ > +static int __init prandom_init_early(void) > +{ > + int i; > + unsigned long v0, v1, v2, v3; > + > + if (!

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:57 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:46:16AM +0200, Sedat Dilek wrote: > > Will you push the updated patchset to your prandom Git - for easy fetching? > > Yeah if you want, feel free to use this one : > > https://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 10:46:16AM +0200, Sedat Dilek wrote: > Will you push the updated patchset to your prandom Git - for easy fetching? Yeah if you want, feel free to use this one : https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise Willy

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > > > +/* > > > + * Generate some initially weak seeding values to allow > > > + * the prandom_u32() engine t

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > +/* > > + * Generate some initially weak seeding values to allow > > + * the prandom_u32() engine to be started. > > + */ > > +static int __init prandom_init_early(voi

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Yann Ylavic
On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > +/* > + * Generate some initially weak seeding values to allow > + * the prandom_u32() engine to be started. > + */ > +static int __init prandom_init_early(void) > +{ > + int i; > + unsigned long v0, v1, v2, v3; > + > +

[PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-08-31 Thread Willy Tarreau
From: George Spelvin Non-cryptographic PRNGs may have great statistical proprties, but are usually trivially predictable to someone who knows the algorithm, given a small sample of their output. An LFSR like prandom_u32() is particularly simple, even if the sample is widely scattered bits. It t