Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

2015-12-09 Thread David Miller
>> To: netdev@vger.kernel.org >> Cc: linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >> p.fe...@samsung.com; >> sunil.gout...@caviumnetworks.com; Sunil Goutham >> Subject: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware >> >>

Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

2015-12-09 Thread Sunil Kovvuri
>> + booltns_mode:1; >> + boolsqs_mode:1; >These little refactors are creeping in your code without even being mentioned in the commit message, this is not good practice. Okay, will include these in the commit message. >IMHO. Additionally, may be t

RE: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

2015-12-09 Thread Pavel Fedin
.@lists.infradead.org; > p.fe...@samsung.com; > sunil.gout...@caviumnetworks.com; Sunil Goutham > Subject: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware > > From: Sunil Goutham > > This adds support for offloading TCP segmentation to HW in pass-2 > revision of h

[PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

2015-12-09 Thread Sunil Goutham
From: Sunil Goutham This adds support for offloading TCP segmentation to HW in pass-2 revision of hardware. Both driver level SW TSO for pass1.x chips and HW TSO for pass-2 chip will co-exist. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h | 12 ++--