Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-07 Thread David Miller
From: Moritz Fischer Date: Fri, 4 May 2018 10:18:33 -0700 > Fix issue where nixge_get_nvmem_address() returns a non-NULL > return value on a failed nvmem_cell_get() that causes an invalid > access when error value encoded in pointer is dereferenced. > > Furthermore ensure that buffer allocated

[PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-04 Thread Moritz Fischer
Fix issue where nixge_get_nvmem_address() returns a non-NULL return value on a failed nvmem_cell_get() that causes an invalid access when error value encoded in pointer is dereferenced. Furthermore ensure that buffer allocated by nvmem_cell_read() actually gets kfreed() if the function succeeds.