On Thu, Jun 11, 2020 at 09:55:23AM +0100, Russell King - ARM Linux admin wrote:
> On Wed, Jun 10, 2020 at 08:14:03PM +0100, Jonathan McDowell wrote:
> > Update the driver to use the new PHYLINK callbacks, removing the
> > legacy adjust_link callback.
>
> Looks good, there's a couple of issues / qu
On Thu, Jun 11, 2020 at 11:58:43AM +0300, Vladimir Oltean wrote:
> Hi Jonathan,
>
> On Wed, 10 Jun 2020 at 23:19, Jonathan McDowell wrote:
> >
> > Update the driver to use the new PHYLINK callbacks, removing the
> > legacy adjust_link callback.
> >
> > Signed-off-by: Jonathan McDowell
...
> > s
Hi Russell,
On Thu, 11 Jun 2020 at 11:57, Russell King - ARM Linux admin
wrote:
>
>
> Alternatively, phylink supports polling mode, but due to the layered
> way DSA is written, DSA drivers don't have access to that as that is
> in the DSA upper levels in net/dsa/slave.c (dsa_slave_phy_setup(),
>
Hi Jonathan,
On Wed, 10 Jun 2020 at 23:19, Jonathan McDowell wrote:
>
> Update the driver to use the new PHYLINK callbacks, removing the
> legacy adjust_link callback.
>
> Signed-off-by: Jonathan McDowell
> ---
> drivers/net/dsa/qca8k.c | 309 +++-
> 1 file c
On Wed, Jun 10, 2020 at 08:14:03PM +0100, Jonathan McDowell wrote:
> Update the driver to use the new PHYLINK callbacks, removing the
> legacy adjust_link callback.
Looks good, there's a couple of issues / questions
> static void
> +qca8k_phylink_mac_config(struct dsa_switch *ds, int port, unsig
On 6/10/2020 12:14 PM, Jonathan McDowell wrote:
> Update the driver to use the new PHYLINK callbacks, removing the
> legacy adjust_link callback.
>
> Signed-off-by: Jonathan McDowell
This looks reasonable to me, Russell would be the person you want to get
an Acked-by/Reviewed-by tag from.
--
Update the driver to use the new PHYLINK callbacks, removing the
legacy adjust_link callback.
Signed-off-by: Jonathan McDowell
---
drivers/net/dsa/qca8k.c | 309 +++-
1 file changed, 212 insertions(+), 97 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/dr
