Re: [PATCH 1/2] net: Let inet_diag and friends autoload

2007-10-19 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 16:21:23 +0800 > David Miller <[EMAIL PROTECTED]> wrote: > > > > I'm concerned it might be dangerous to load the module in > > this context, the RTNL semaphore is held and the module we > > are requesting could easily try to take it and d

Re: [PATCH 1/2] net: Let inet_diag and friends autoload

2007-10-19 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > I'm concerned it might be dangerous to load the module in > this context, the RTNL semaphore is held and the module we > are requesting could easily try to take it and deadlock. We shouldn't be holding the RTNL here. AFAICS we only hold inet_diag_mutex

Re: [PATCH 1/2] net: Let inet_diag and friends autoload

2007-10-17 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 17:28:23 +0200 > By adding module aliases to inet_diag, tcp_diag and dccp_diag, we let > them load automatically as needed. This makes tools like "ss" run > faster. > > Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> > Cc: Alexey Kuzne

[PATCH 1/2] net: Let inet_diag and friends autoload

2007-10-16 Thread Jean Delvare
By adding module aliases to inet_diag, tcp_diag and dccp_diag, we let them load automatically as needed. This makes tools like "ss" run faster. Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> Cc: Alexey Kuznetsov <[EMAIL PROTECTED]> --- The alias naming scheme for tcp_diag and dccp_diag follows wh