Re: [PATCH 1/2] napi_synchronize: waiting for NAPI

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 18:26 -0700, Stephen Hemminger wrote: > > Could you give a concrete example as to why it needs a smp barrier? > The test_bit is going to get a consistent result. Are you worried about > operations ordering before the test_bit()? In that case, one of those > smp_mb__before_xx

Re: [PATCH 1/2] napi_synchronize: waiting for NAPI

2007-10-17 Thread Stephen Hemminger
On Thu, 18 Oct 2007 10:28:09 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Wed, 2007-10-17 at 13:26 -0700, Stephen Hemminger wrote: > > plain text document attachment (napi-synchronize.patch) > > Some drivers with shared NAPI need a synchronization barrier. > > Also suggested by

Re: [PATCH 1/2] napi_synchronize: waiting for NAPI

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 13:26 -0700, Stephen Hemminger wrote: > plain text document attachment (napi-synchronize.patch) > Some drivers with shared NAPI need a synchronization barrier. > Also suggested by Benjamin Herrenschmidt for EMAC. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Just

Re: [PATCH 1/2] napi_synchronize: waiting for NAPI

2007-10-17 Thread Jeff Garzik
applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] napi_synchronize: waiting for NAPI

2007-10-17 Thread Stephen Hemminger
Some drivers with shared NAPI need a synchronization barrier. Also suggested by Benjamin Herrenschmidt for EMAC. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/linux/netdevice.h 2007-10-17 08:45:32.0 -0700 +++ b/include/linux/netdevice.h 2007-10-17 08:47:54.0 -