Re: [PATCH 1/2] mpls: add handlers

2017-08-16 Thread Amine Kherbouche
On 08/16/2017 07:30 AM, Roopa Prabhu wrote: On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] I think the reverse is the better option, removing the vpls device information and just going with the route table. My approach to this would be to add a new netlink route attribute "

Re: [PATCH 1/2] mpls: add handlers

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] > I think the reverse is the better option, removing the vpls device > information and just going with the route table. My approach to this > would be to add a new netlink route attribute "RTA_VPLS" which > identifies the vpls devic

Re: [PATCH 1/2] mpls: add handlers

2017-08-15 Thread David Lamparter
On Sat, Aug 12, 2017 at 08:29:18PM -0700, Roopa Prabhu wrote: > On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche > wrote: > > > > > > On 11/08/2017 16:37, Roopa Prabhu wrote: > >> > >> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter > >> wrote: > >>> > >>> On Thu, Aug 10, 2017 at 10:28:36PM +02

Re: [PATCH 1/2] mpls: add handlers

2017-08-12 Thread Roopa Prabhu
On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche wrote: > > > On 11/08/2017 16:37, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter >> wrote: >>> >>> On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: Mpls handler allows creation/deletion of mpl

Re: [PATCH 1/2] mpls: add handlers

2017-08-12 Thread Amine Kherbouche
On 11/08/2017 16:37, Roopa Prabhu wrote: On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote: On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: Mpls handler allows creation/deletion of mpls routes without using rtnetlink. When an incoming mpls packet matches this route, th

Re: [PATCH 1/2] mpls: add handlers

2017-08-11 Thread Roopa Prabhu
On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote: > On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: >> Mpls handler allows creation/deletion of mpls routes without using >> rtnetlink. When an incoming mpls packet matches this route, the saved >> function handler is called.

Re: [PATCH 1/2] mpls: add handlers

2017-08-11 Thread David Lamparter
On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: > Mpls handler allows creation/deletion of mpls routes without using > rtnetlink. When an incoming mpls packet matches this route, the saved > function handler is called. Since I originally authored this patch, I have come to believ

[PATCH 1/2] mpls: add handlers

2017-08-10 Thread Amine Kherbouche
Mpls handler allows creation/deletion of mpls routes without using rtnetlink. When an incoming mpls packet matches this route, the saved function handler is called. Signed-off-by: Amine Kherbouche Signed-off-by: David Lamparter --- include/net/mpls.h | 10 +++ net/mpls/af_mpls.c | 75