Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-13 Thread Kalle Valo
"Coelho, Luciano" writes: >> BTW, I thought network people don't want to have Cc-to-stable in the >> patch, so I didn't put it by myself. Is this rule still valid? > > In the wireless side of network, we've always used Cc stable when > needed Yeah, we handle stable patches differently from the

Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Coelho, Luciano
On Tue, 2021-01-12 at 17:02 +0100, Takashi Iwai wrote: > On Tue, 12 Jan 2021 16:48:56 +0100, > Kalle Valo wrote: > > > > Takashi Iwai writes: > > > > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > > > memory") added a termination of name string just to be sure, and this >

Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:48:56 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > > memory") added a termination of name string just to be sure, and this > > seems causing a regression, a GPF triggered at firmware loading. >

Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Kalle Valo
Takashi Iwai writes: > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > memory") added a termination of name string just to be sure, and this > seems causing a regression, a GPF triggered at firmware loading. > Basically we shouldn't modify the firmware data that may be provid

[PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Takashi Iwai
The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") added a termination of name string just to be sure, and this seems causing a regression, a GPF triggered at firmware loading. Basically we shouldn't modify the firmware data that may be provided as read-only. This patch dr