Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-08-01 Thread Julia Lawall
On Tue, 1 Aug 2017, David Ahern wrote: > On 7/31/17 11:59 PM, Julia Lawall wrote: > >> This change breaks the kernel if one of these sysctls are changed: > >> tcp_early_demux, udp_early_demux > > > > The other patch in the series has the same problem and should be dropped > > too. > > > > julia

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-08-01 Thread David Ahern
On 7/31/17 11:59 PM, Julia Lawall wrote: >> This change breaks the kernel if one of these sysctls are changed: >> tcp_early_demux, udp_early_demux > > The other patch in the series has the same problem and should be dropped > too. > > julia Julia: are you going to send a revert patch? Right now

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-07-31 Thread Julia Lawall
On Mon, 31 Jul 2017, Eric Dumazet wrote: > On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > > The inet6_protocol structure is only passed as the first argument to > > inet6_add_protocol or inet6_del_protocol, both of which are declared as > > const. Thus the inet6_protocol structure its

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-07-31 Thread Julia Lawall
On Mon, 31 Jul 2017, Eric Dumazet wrote: > On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > > The inet6_protocol structure is only passed as the first argument to > > inet6_add_protocol or inet6_del_protocol, both of which are declared as > > const. Thus the inet6_protocol structure its

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-07-31 Thread Eric Dumazet
On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > The inet6_protocol structure is only passed as the first argument to > inet6_add_protocol or inet6_del_protocol, both of which are declared as > const. Thus the inet6_protocol structure itself can be const. > > Also drop __read_mostly where

[PATCH 1/2] ipv6: constify inet6_protocol structures

2017-07-28 Thread Julia Lawall
The inet6_protocol structure is only passed as the first argument to inet6_add_protocol or inet6_del_protocol, both of which are declared as const. Thus the inet6_protocol structure itself can be const. Also drop __read_mostly where present on the newly const structures. Done with the help of Co