Re: [PATCH 1/2] forcedeth: coding style cleanups (rev2)

2006-07-27 Thread Michael Buesch
On Thursday 27 July 2006 21:24, Stephen Hemminger wrote: > On Thu, 27 Jul 2006 21:21:14 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > On Thursday 27 July 2006 19:48, Stephen Hemminger wrote: > > > --- sky2.orig/drivers/net/forcedeth.c 2006-07-13 12:53:48.0 > > > -0700 > > >

Re: [PATCH 1/2] forcedeth: coding style cleanups (rev2)

2006-07-27 Thread Stephen Hemminger
On Thu, 27 Jul 2006 21:21:14 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > On Thursday 27 July 2006 19:48, Stephen Hemminger wrote: > > --- sky2.orig/drivers/net/forcedeth.c 2006-07-13 12:53:48.0 > > -0700 > > +++ sky2/drivers/net/forcedeth.c2006-07-27 10:45:49.0 -07

Re: [PATCH 1/2] forcedeth: coding style cleanups (rev2)

2006-07-27 Thread Michael Buesch
On Thursday 27 July 2006 19:48, Stephen Hemminger wrote: > --- sky2.orig/drivers/net/forcedeth.c 2006-07-13 12:53:48.0 -0700 > +++ sky2/drivers/net/forcedeth.c 2006-07-27 10:45:49.0 -0700 > @@ -381,21 +381,21 @@ > > /* Big endian: should work, but is untested */ > struct ri

[PATCH 1/2] forcedeth: coding style cleanups (rev2)

2006-07-27 Thread Stephen Hemminger
Fix the coding style of the nForce Ethernet driver. - typedef's should not be used - variable names should not be capitialized - structure tags should be lower case - add whitespace near keywords - don't add paren's to switch cases - remove paren's from return - don't use __constant_ntohs un