From: Arnd Bergmann
Date: Fri, 18 Sep 2020 14:05:18 +0200
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
...
> +static inline bool ethtool_translate_compat(void)
> +{
Please don't use the inline keyword in foo.c files.
Thank you.
> + if (ethtool_translate_compat()) {
> + struct compat_ethtool_rxnfc crxnfc = {};
> +
> + if (copy_from_user(&crxnfc, useraddr,
> +min(size, sizeof(crxnfc
> + return -EFAULT;
> +
> + *rxnfc = (struct et
The ethtool compat ioctl handling is hidden away in net/socket.c,
which introduces a couple of minor oddities:
- The implementation may end up diverging, as seen in the RXNFC
extension in commit 84a1d9c48200 ("net: ethtool: extend RXNFC
API to support RSS spreading of filter matches") that doe
