Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 13:45:42 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > applied, then I fixed up all the drivers > > Otherwise, it was a half-complete job that would take years to get > cleaned up. > > Thanks, I did the same effective patch last night but doing a "make allmodconfig" buil

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-13 Thread Jeff Garzik
applied, then I fixed up all the drivers Otherwise, it was a half-complete job that would take years to get cleaned up. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-in

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Jeff Garzik
How hard can it be to grep? Can you please just provide the patch?? Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Stephen Hemminger
On Tue, 12 Sep 2006 12:08:03 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > The ethtool_ops structure is immutable, it expected to be setup > > by the driver and is never changed. This patch allows drivers to > > declare there ethtool_ops structure read-only. > > > >

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Stephen Hemminger
On Tue, 12 Sep 2006 22:12:30 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > No, they can pass non-const and everthing works. > > Changing the ethtool_ops to have const args would require a global change. > > Re-stating previous email: I need a patch which updates all

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Jeff Garzik
Stephen Hemminger wrote: No, they can pass non-const and everthing works. Changing the ethtool_ops to have const args would require a global change. Re-stating previous email: I need a patch which updates all drivers to declare their ethtool_ops structs const. Jeff - To unsubscrib

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Stephen Hemminger
On Tue, 12 Sep 2006 12:08:03 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > The ethtool_ops structure is immutable, it expected to be setup > > by the driver and is never changed. This patch allows drivers to > > declare there ethtool_ops structure read-only. > > > >

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-12 Thread Jeff Garzik
Stephen Hemminger wrote: The ethtool_ops structure is immutable, it expected to be setup by the driver and is never changed. This patch allows drivers to declare there ethtool_ops structure read-only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ACK, but I need the associated change-al

[PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-08 Thread Stephen Hemminger
The ethtool_ops structure is immutable, it expected to be setup by the driver and is never changed. This patch allows drivers to declare there ethtool_ops structure read-only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.orig/include/linux/netdevice.h +++ linux-2.6/include/