Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-10 Thread Jakub Kicinski
On Tue, 10 Nov 2020 08:19:32 -0300 Thadeu Lima de Souza Cascardo wrote: > Yeah, I agree with your initial email. The patch I submitted for that fix > needs > rework, which is what I tried and failed so far. I need to get back to some > testing of my latest fix and find out what needs fixing there.

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-10 Thread Thadeu Lima de Souza Cascardo
On Mon, Nov 09, 2020 at 02:15:53PM -0800, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 18:31:34 -0300 Thadeu Lima de Souza Cascardo wrote: > > > Which paths are those (my memory of this code is waning)? I thought > > > disconnect is only called from the user space side (shutdown syscall). > > > The o

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 18:31:34 -0300 Thadeu Lima de Souza Cascardo wrote: > > Which paths are those (my memory of this code is waning)? I thought > > disconnect is only called from the user space side (shutdown syscall). > > The only other way to terminate the connection is to close the socket, > > wh

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Thadeu Lima de Souza Cascardo
On Mon, Nov 09, 2020 at 01:15:54PM -0800, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 18:09:09 -0300 Thadeu Lima de Souza Cascardo wrote: > > On Mon, Nov 09, 2020 at 09:49:38AM -0800, Jakub Kicinski wrote: > > > On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > > > > On Fri,

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 18:09:09 -0300 Thadeu Lima de Souza Cascardo wrote: > On Mon, Nov 09, 2020 at 09:49:38AM -0800, Jakub Kicinski wrote: > > On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > > > On Fri, Oct 16, 2020 at 03:30:16PM -0700, Jakub Kicinski wrote: > > > > On Tu

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Thadeu Lima de Souza Cascardo
On Mon, Nov 09, 2020 at 09:49:38AM -0800, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > > On Fri, Oct 16, 2020 at 03:30:16PM -0700, Jakub Kicinski wrote: > > > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > > > From: Thad

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 08:48:28 -0300 Thadeu Lima de Souza Cascardo wrote: > On Fri, Oct 16, 2020 at 03:30:16PM -0700, Jakub Kicinski wrote: > > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > > From: Thadeu Lima de Souza Cascardo > > > > > > When dccps_hc_tx_ccid is freed,

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-11-09 Thread Thadeu Lima de Souza Cascardo
On Fri, Oct 16, 2020 at 03:30:16PM -0700, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > From: Thadeu Lima de Souza Cascardo > > > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > > del_timer_sync can't be used is becau

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-16 Thread Jakub Kicinski
On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a p

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-15 Thread Thadeu Lima de Souza Cascardo
On Wed, Oct 14, 2020 at 08:43:22PM -0700, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > From: Thadeu Lima de Souza Cascardo > > > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > > del_timer_sync can't be used is becau

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-14 Thread Jakub Kicinski
On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a p

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Richard Sailer
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a pointer to dccp

[PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Kleber Sacilotto de Souza
From: Thadeu Lima de Souza Cascardo When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason del_timer_sync can't be used is because this relies on keeping a reference to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that during disconnect, the timer should r