Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-16 Thread Michael Buesch
On Saturday 16 December 2006 07:40, Michael Wu wrote: > On Thursday 14 December 2006 13:20, Michael Buesch wrote: > > -int ieee80211_update_hw(struct ieee80211_hw *hw) > > +int ieee80211_register_hwmode(struct ieee80211_hw *hw, > > + struct ieee80211_hw_mode *mode) > Looks l

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Wu
On Thursday 14 December 2006 13:20, Michael Buesch wrote: > -int ieee80211_update_hw(struct ieee80211_hw *hw) > +int ieee80211_register_hwmode(struct ieee80211_hw *hw, > + struct ieee80211_hw_mode *mode) Looks like this function never returns nonzero now. Can it return voi

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 15:06, Jiri Benc wrote: > On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > > Can you also apply the bcm43xx fix for this to your tree? > > I think that should be easiest and prevent long-living breakage. > > It doesn't apply :-( It's probably easy to fix but I

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 15:06, Jiri Benc wrote: > On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > > Can you also apply the bcm43xx fix for this to your tree? > > I think that should be easiest and prevent long-living breakage. > > It doesn't apply :-( It's probably easy to fix but I

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Jiri Benc
On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > Can you also apply the bcm43xx fix for this to your tree? > I think that should be easiest and prevent long-living breakage. It doesn't apply :-( It's probably easy to fix but I'd rather leave it to you to not make any damage. Thanks,

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 14:48, Jiri Benc wrote: > On Thu, 14 Dec 2006 19:20:11 +0100, Michael Buesch wrote: > > This turns the PHY-modes list into a linked list. > > The advantage is that drivers can add modes dynamically, as they probe > > them and don't have to settle to a given arraysize at t

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Jiri Benc
On Thu, 14 Dec 2006 19:20:11 +0100, Michael Buesch wrote: > This turns the PHY-modes list into a linked list. > The advantage is that drivers can add modes dynamically, as they probe > them and don't have to settle to a given arraysize at the beginning > of probing. ACK. > @@ -198,8 +200,7 @@ sta

[PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-14 Thread Michael Buesch
This turns the PHY-modes list into a linked list. The advantage is that drivers can add modes dynamically, as they probe them and don't have to settle to a given arraysize at the beginning of probing. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> -- Note that I will also send fixup patches f