RE: [PATCH 1/2] batman-adv: Fix double call of dev_queue_xmit

2017-01-30 Thread David Laight
From: Simon Wunderlich > Sent: 28 January 2017 10:57 > From: Sven Eckelmann > > The net_xmit_eval has side effects because it is not making sure that e > isn't evaluated twice. > > #define net_xmit_eval(e)((e) == NET_XMIT_CN ? 0 : (e)) It is probably worth fixing the #define.

[PATCH 1/2] batman-adv: Fix double call of dev_queue_xmit

2017-01-28 Thread Simon Wunderlich
From: Sven Eckelmann The net_xmit_eval has side effects because it is not making sure that e isn't evaluated twice. #define net_xmit_eval(e)((e) == NET_XMIT_CN ? 0 : (e)) The code requested by David Miller [1] return net_xmit_eval(dev_queue_xmit(skb)); will get transformed int