Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 16:11:47 +0300 > One proc_net_create() user less. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Please make the corrections suggested in the feedback for this patch and resubmit. Thanks! - To unsubscribe from this list: s

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Patrick McHardy
Stephen Hemminger wrote: On Tue, 30 Oct 2007 16:11:47 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: +static const struct file_operations ipv6_route_proc_fops = { + .open = ipv6_route_open, + .read = seq_read, + .llseek = seq_lseek, + .rele

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Stephen Hemminger
On Tue, 30 Oct 2007 16:11:47 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > +static const struct file_operations ipv6_route_proc_fops = { > + .open = ipv6_route_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release= single_rele

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Benjamin Thery
Cosmetic comment: I forgot to say there are a few indentation "errors" when I apply your patch. See below. Benjamin Thery wrote: > Alexey Dobriyan wrote: >> One proc_net_create() user less. > > Funny, I was working on a similar patch. > > See comment below. > > >> Signed-off-by: Alexey Dobri

Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Benjamin Thery
Alexey Dobriyan wrote: > One proc_net_create() user less. Funny, I was working on a similar patch. See comment below. > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > net/ipv6/route.c | 70 > +++ > 1 file changed, 25 inserti

[PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-10-30 Thread Alexey Dobriyan
One proc_net_create() user less. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/ipv6/route.c | 70 +++ 1 file changed, 25 insertions(+), 45 deletions(-) --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2288,71 +2288,49 @@ struct