Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Al Viro
On Wed, Jul 25, 2007 at 12:30:07AM +0100, Al Viro wrote: > On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote: > > Could you point me to an example you have in mind? > > > > I quickly searched through a handful of the PCI device drivers and > > couldn't find an example where the .remo

RE: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Waskiewicz Jr, Peter P
> * netdev_pci_remove_one() can replace simple pci device remove > functions > > * devm_alloc_netdev() is like alloc_netdev but allocates > memory using devres. > alloc_netdev() can be removed once all drivers use devres. Please look at the multiqueue network code that is in 2.6.23. It crea

Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Al Viro
On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote: > Could you point me to an example you have in mind? > > I quickly searched through a handful of the PCI device drivers and > couldn't find an example where the .remove function didn't do something > to the tune of: > > unregi

Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Brandon Philips
On 00:09 Wed 25 Jul 2007, Al Viro wrote: > On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote: > > On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote: > > > * netdev_pci_remove_one() can replace simple pci device remove > > > functions > > > > > > * devm_alloc_netdev() is lik

Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Al Viro
On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote: > On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote: > > * netdev_pci_remove_one() can replace simple pci device remove > > functions > > > > * devm_alloc_netdev() is like alloc_netdev but allocates memory using > > devres

Re: [PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread Al Viro
On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote: > * netdev_pci_remove_one() can replace simple pci device remove > functions > > * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres. > alloc_netdev() can be removed once all drivers use devres. E

[PATCH 1/2][RFC] Update net core to use devres.

2007-07-24 Thread bphilips
* netdev_pci_remove_one() can replace simple pci device remove functions * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres. alloc_netdev() can be removed once all drivers use devres. Applies against 2.6.22 Signed-off-by: Brandon Philips <[EMAIL PROTECTED]> --- in