Re: [PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 20:42:38 +0100 > On Wed, 14 Nov 2007 21:08:29 +0300 > Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > > > The request_sock_queue's listen_opt is either vmalloc-ed or > > kmalloc-ed depending on the number of table entries. Thus it > > is

Re: [PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread Eric Dumazet
On Wed, 14 Nov 2007 21:08:29 +0300 Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > The request_sock_queue's listen_opt is either vmalloc-ed or > kmalloc-ed depending on the number of table entries. Thus it > is expected to be handled properly on free, which is done in > the reqsk_queue_destroy(). >

[PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread Pavel Emelyanov
The request_sock_queue's listen_opt is either vmalloc-ed or kmalloc-ed depending on the number of table entries. Thus it is expected to be handled properly on free, which is done in the reqsk_queue_destroy(). However the error path in inet_csk_listen_start() calls the lite version of reqsk_queu