On Thu, 2007-02-01 at 20:48 -0800, Roland Dreier wrote:
> > Have you had a chance to review this?
>
> Still on my list.
>
> Can we trade? Can you look at the IPoIB connected mode stuff in the
> ipoib-cm branch in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git
>
>
> Have you had a chance to review this?
Still on my list.
Can we trade? Can you look at the IPoIB connected mode stuff in the
ipoib-cm branch in
git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git
and let me know if you see anything you don't like?
- R.
-
To unsubscribe
On Fri, 2007-01-19 at 09:07 -0800, Roland Dreier wrote:
> > Jeff has pulled in the Chelsio Ethernet driver. If you are ready to
> > merge in the RDMA driver, you can pull it from
>
> Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff.
Hey Roland,
Have you had a chance to
> Jeff has pulled in the Chelsio Ethernet driver. If you are ready to
> merge in the RDMA driver, you can pull it from
Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL
Le Ray <[EMAIL PROTECTED]>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
[EMAIL PROTECTED]
Subject: Re: [PATCH 1/10] cxgb3 - main header files
Date: Thu, 18 Jan 2007 22:05:02 -0500
Divy Le Ray wrote:
> Jeff Garzik wrote:
>> Divy Le Ray wrote:
>>> From:
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
Once you think it's ready, email me a URL to a single patch that adds
>
> In the interest of expediting this I'll go implement it...
>
> Steve.
>
Here it is. I think this is the correct way to solve the issue (now
that I've implemented it :). This is a delta from the driver patch
series just for reviewing purposes.
commit e6053f2aee764b21e28cbb19f52995cb413c
openib-general
> Subject: Re: [openib-general] [PATCH 1/10] cxgb3 - main header files
>
> > We also need to decide on the ib_req_notify_cq() issue.
>
> Let's clarify - do you oppose doing copy_from_user from a
> fixed address passed in during setup?
>
> If
> The time for adding new stuff to 2.6.20 is /long/ past. We stop
> adding things like new drivers when Linus releases 2.6.X-rc1.
Well, in the past I think new drivers have been added after the merge
window, given that there's no chance of regressions (old kernel == no
support for device X, so
Roland Dreier wrote:
> > You can grab the monolithic patch at this URL:
> > http://service.chelsio.com/kernel.org/cxgb3.patch.bz2
>
> this is in my queue, thanks. Sorry I didn't indicate that earlier.
When do you plan to merge it? For 2.6.20 or .21?
The time for adding new stuff to 2.6
> > You can grab the monolithic patch at this URL:
> > http://service.chelsio.com/kernel.org/cxgb3.patch.bz2
>
> this is in my queue, thanks. Sorry I didn't indicate that earlier.
When do you plan to merge it? For 2.6.20 or .21?
I'm trying to understand when the RDMA stuff that depends on
On Tue, 2007-01-09 at 15:57 +0200, Michael S. Tsirkin wrote:
> > We also need to decide on the ib_req_notify_cq() issue.
>
> Let's clarify - do you oppose doing copy_from_user from a fixed
> address passed in during setup?
>
So far its been you and I arguing over this issue. Before I go
imple
> We also need to decide on the ib_req_notify_cq() issue.
Let's clarify - do you oppose doing copy_from_user from a fixed
address passed in during setup?
If OK with you, this seems the best way as it is the least controversial
and least disruptive one.
--
MST
-
To unsubscribe from this list:
Roland,
The T3 Ethernet driver is queued for inclusion into Jeff's tree.
How do you want to merge in the RDMA driver? I can give you a single
monolithic patch if you want.
We also need to decide on the ib_req_notify_cq() issue.
Steve.
On Tue, 2007-01-09 at 05:28 -0500, Jeff Garzik wr
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
Once you think it's ready, email me a URL to a single patch that adds
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
Once you think it's ready, email me a URL to a single patch that adds
the driver to the la
On Wed, 2006-12-27 at 00:52 -0800, Divy Le Ray wrote:
> Jeff,
>
> You can grab the monolithic patch at this URL:
> http://service.chelsio.com/kernel.org/cxgb3.patch.bz2
>
> This patch adds support for the latest 1G/10G Chelsio adapter, T3.
> It is required by the T3 RDMA driver Steve Wise submitt
Jeff,
You can grab the monolithic patch at this URL:
http://service.chelsio.com/kernel.org/cxgb3.patch.bz2
This patch adds support for the latest 1G/10G Chelsio adapter, T3.
It is required by the T3 RDMA driver Steve Wise submitted.
Here is a brief description of its content:
drivers/net/cxgb3
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
Once you think it's ready, email me a URL to a single patch that adds
the driver to the latest linux-2.6.git k
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 255
drivers/net/cxgb3/common.h | 709 ++
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 255
drivers/net/cxgb3/common.h | 709 ++
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 255
drivers/net/cxgb3/common.h | 709 ++
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 255
drivers/net/cxgb3/common.h | 710 ++
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 250
drivers/net/cxgb3/common.h | 704 ++
On Nov 17 2006 12:23, Divy Le Ray <[EMAIL PROTECTED]> wrote:
>Subject: [PATCH 1/10] cxgb3 - main header files
(For all files)
Some suggestions:
* change the typedefs to struct, this includes:
adapter_t -> struct adapter
* function prototypes and function
> > +#define MDIO_LOCK(adapter) down(&(adapter)->mdio_lock)
> > +#define MDIO_UNLOCK(adapter) up(&(adapter)->mdio_lock)
>
> Please don't wrap locks
Plus these should probably be mutexes, not semaphores.
> > +int t3_offload_tx(struct t3cdev *tdev, struct sk_buff *skb);
>
> What kind of of
> +
> +struct work_struct;
> +struct dentry;
Why do you need these extra forward declarations?
...
> +
> +struct sge_rspq { /* state for an SGE response queue */
> + unsigned int credits; /* # of pending response credits */
> + unsigned int size; /* cap
From: Divy Le Ray <[EMAIL PROTECTED]>
This patch implements the main header files of
the Chelsio T3 network driver.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 317 +++
drivers/net/cxgb3/common.h | 702 +++
28 matches
Mail list logo
