Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-19 Thread David Miller
From: Paul Bolle Date: Thu, 18 Feb 2016 21:29:08 +0100 > The purpose of gigaset_device_release() is to kfree() the struct > ser_cardstate that contains our struct device. This is done via a bit of > a detour. First we make our struct device's driver_data point to the > container of our struct ser

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Paul Bolle
Hi Greg, On do, 2016-02-18 at 15:46 -0800, Greg KH wrote: > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > What in my submission triggers this formletter? Thank

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Greg KH
On Thu, Feb 18, 2016 at 09:29:08PM +0100, Paul Bolle wrote: > The purpose of gigaset_device_release() is to kfree() the struct > ser_cardstate that contains our struct device. This is done via a bit of > a detour. First we make our struct device's driver_data point to the > container of our struct

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Paul Bolle
On do, 2016-02-18 at 22:42 +0100, Tilman Schmidt wrote: > Acked-by: Tilman Schmidt > > Thanks for cleaning up the mess I left behind. That's not how I look at it. Commit 4c5e354a9742 ("ser_gigaset: fix deallocation of platform device structure") provided a plausible fix for the issue we were tr

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Tilman Schmidt
Am 18.02.2016 um 21:29 schrieb Paul Bolle: > The purpose of gigaset_device_release() is to kfree() the struct > ser_cardstate that contains our struct device. This is done via a bit of > a detour. First we make our struct device's driver_data point to the > container of our struct ser_cardstate (wh

[PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Paul Bolle
The purpose of gigaset_device_release() is to kfree() the struct ser_cardstate that contains our struct device. This is done via a bit of a detour. First we make our struct device's driver_data point to the container of our struct ser_cardstate (which is a struct cardstate). In gigaset_device_relea