Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-17 Thread David Miller
From: Xue Chaojing Date: Sun, 16 Dec 2018 22:32:34 + > In rx_alloc_pkts(), there is no need to schedule a different tasklet for > refill and it will cause some extra overhead. this patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing In future submissions please fo

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-17 Thread Neil Horman
On Sun, Dec 16, 2018 at 10:32:34PM +, Xue Chaojing wrote: > In rx_alloc_pkts(), there is no need to schedule a different tasklet for > refill and it will cause some extra overhead. this patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing > --- > drivers/net/ethernet

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-16 Thread Xue Chaojing
In rx_alloc_pkts(), there is no need to schedule a different tasklet for refill and it will cause some extra overhead. this patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/hua

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-15 Thread David Miller
From: Xue Chaojing Date: Sun, 9 Dec 2018 19:14:19 + > There is no need to schedule a different tasklet for refill, > This patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing I completely agree with Neil's analysis. You should never receive a packet if refilling t

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-13 Thread Neil Horman
On Wed, Dec 12, 2018 at 05:40:23PM +, Xue Chaojing wrote: > There is no need to schedule a different tasklet for refill, > This patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing > --- > drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- > driv

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-12 Thread Xue Chaojing
There is no need to schedule a different tasklet for refill, This patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 2 -- 2 files changed, 5 insertion

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-09 Thread Xue Chaojing
There is no need to schedule a different tasklet for refill, This patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 2 -- 2 files changed, 5 insertion