Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-21 Thread David Miller
From: Frans Klaver Date: Wed, 17 Jun 2015 10:30:18 +0200 > Ah, that explains something. If retire timer is not going to be needed > for tx, wouldn't it be better to remove the whole tx_ring handling > from this function altogether, rather than changing the BUG()? Agreed. -- To unsubscribe from t

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-17 Thread Frans Klaver
On Wed, Jun 17, 2015 at 10:26 AM, Alexander Drozdov wrote: > On Wed, 17 Jun 2015 09:36:11 +0200, Frans Klaver wrote: >> >> On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh >> wrote: >>> >>> Use BUG_ON(condition) instead of if(condition)/BUG() . >>> >>> Signed-off-by: Maninder Singh >>> Reviewed-b

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-17 Thread Alexander Drozdov
On Wed, 17 Jun 2015 09:36:11 +0200, Frans Klaver wrote: On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh wrote: Use BUG_ON(condition) instead of if(condition)/BUG() . Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- net/packet/af_packet.c |3 +-- 1 files changed, 1 inserti

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-17 Thread Frans Klaver
On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh wrote: > Use BUG_ON(condition) instead of if(condition)/BUG() . > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar > --- > net/packet/af_packet.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/net/pack

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-16 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 10:06:01AM +0530, Maninder Singh wrote: > Use BUG_ON(condition) instead of if(condition)/BUG() . > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar Why not? Acked-by: Michael S. Tsirkin > --- > net/packet/af_packet.c |3 +-- > 1 files changed, 1 ins

Re: Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

2015-06-16 Thread Maninder Singh
Hi David, >> Use BUG_ON(condition) instead of if(condition)/BUG() >> >> Signed-off-by: Maninder Singh >> Reviewed-by: Akhilesh Kumar >Your email client corrupted this patch, making it unusable I resent the patch with git send-mail , it results ok, hopefully it does not corrupt it. Thanks

[RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-16 Thread Maninder Singh
Use BUG_ON(condition) instead of if(condition)/BUG() . Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- net/packet/af_packet.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b5989c6..c91d405 100644 --

Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

2015-06-15 Thread David Miller
From: Maninder Singh Date: Mon, 15 Jun 2015 10:35:05 +0530 > Use BUG_ON(condition) instead of if(condition)/BUG() > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar Your email client corrupted this patch, making it unusable. -- To unsubscribe from this list: send the line "unsubs

[PATCH 1/1] net: replace if()/BUG with BUG_ON()

2015-06-14 Thread Maninder Singh
Use BUG_ON(condition) instead of if(condition)/BUG() Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- net/packet/af_packet.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b5989c6..c91d405 100644 ---