Re: [PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-19 Thread David Miller
From: Heinrich Schuchardt Date: Tue, 17 May 2016 22:01:15 +0200 > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt I agree with others that this assert() is pretty useless and should simply be

RE: [PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-19 Thread David Laight
From: Heinrich Schuchardt > Sent: 17 May 2016 21:01 > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 8 > 1 file changed, 4

Re: [PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-17 Thread Yisen Zhuang
Hi Heinrich, This patch is fine to me. Thanks, Yisen 在 2016/5/18 4:01, Heinrich Schuchardt 写道: > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/ethernet/hisilicon/hns/h

[PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
In the statement assert(priv || priv->ae_handle); the right side of || is only evaluated if priv is null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/his