Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Pan Bian
From: PanBian Hi, Lino, There is no special reason to map different errors to -EIO. In the original source code, err is set to -EIO on most error paths. I copied that. I guess it has no difference with the error value provided by the called functions in the view of callers of typhoon_init_one(

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Lino Sanfilippo
Hi, On 03.12.2016 14:24, Pan Bian wrote: > From: Pan Bian > > In function typhoon_init_one(), returns the value of variable err on > errors. However, on some error paths, variable err is not set to a > negative errno. This patch assigns "-EIO" to err on those paths. > > Signed-off-by: Pan Bian

[PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function typhoon_init_one(), returns the value of variable err on errors. However, on some error paths, variable err is not set to a negative errno. This patch assigns "-EIO" to err on those paths. Signed-off-by: Pan Bian --- drivers/net/ethernet/3com/typhoon.c | 3 +++ 1 fil