RE: [PATCH 1/1] mwifiex: remove superfluous condition

2016-08-01 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Heinrich Schuchardt > Subject: [

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Kalle Valo
Heinrich Schuchardt writes: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt Please try to make the commit titles unique, for example you can use function names or something else. Adding "(2)" is not the

[PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Heinrich Schuchardt
We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell/mwi

[PATCH 1/1] mwifiex: remove superfluous condition

2016-07-31 Thread Heinrich Schuchardt
for_each_property_of_node is only executed if the property prop is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wir