Re: [PATCH 1/1] macsec: reflect the master interface state

2018-10-28 Thread Radu Rendec
On Mon, 2018-10-01 at 14:52 +0200, Sabrina Dubroca wrote: > 2018-09-19, 12:44:41 -0400, Radu Rendec wrote: > > Hello, > > Gah, sorry, this fell into the "week-end" crack and I forgot to answer :( No worries. I was on vacation in the meantime, hence my late reply. > > On Wed, Sep 19, 2018 at 11:24

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-10-01 Thread Sabrina Dubroca
2018-09-19, 12:44:41 -0400, Radu Rendec wrote: > Hello, Gah, sorry, this fell into the "week-end" crack and I forgot to answer :( > On Wed, Sep 19, 2018 at 11:24 AM Sabrina Dubroca wrote: > > 2018-09-18, 20:16:12 -0400, Radu Rendec wrote: > > > This patch makes macsec interfaces reflect the stat

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-09-19 Thread Radu Rendec
Hello, On Wed, Sep 19, 2018 at 11:24 AM Sabrina Dubroca wrote: > 2018-09-18, 20:16:12 -0400, Radu Rendec wrote: > > This patch makes macsec interfaces reflect the state of the underlying > > interface: if the master interface changes state to up/down, the macsec > > interface changes its state ac

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-09-19 Thread Sabrina Dubroca
Hello, 2018-09-18, 20:16:12 -0400, Radu Rendec wrote: > This patch makes macsec interfaces reflect the state of the underlying > interface: if the master interface changes state to up/down, the macsec > interface changes its state accordingly. I got a separate report of the same issue and I've be

[PATCH 1/1] macsec: reflect the master interface state

2018-09-18 Thread Radu Rendec
This patch makes macsec interfaces reflect the state of the underlying interface: if the master interface changes state to up/down, the macsec interface changes its state accordingly. This closes a loophole in the macsec interface state logic: the macsec interface cannot be brought up if the maste