Re: [PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-29 Thread Jeff Garzik
Lennert Buytenhek wrote: gcc4 doesn't like us declaring a static function inside another function. We can do away with this construct altogether and use BUILD_BUG_ON() instead (idea from Andi Kleen.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> applied - To unsubscribe from this lis

[PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-29 Thread Lennert Buytenhek
gcc4 doesn't like us declaring a static function inside another function. We can do away with this construct altogether and use BUILD_BUG_ON() instead (idea from Andi Kleen.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> --- linux-2.6.16-git16/drivers/net/ixp2000/ixpdev.c.orig2006

Re: [PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-26 Thread Andi Kleen
On Sunday 26 March 2006 21:18, Lennert Buytenhek wrote: > gcc4 doesn't allow declaring a static function inside another function, > so convert to extern. (The function whose prototype we're changing is > not defined anywhere and intended purely to cause a link error when some > internal calculatio

[PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-26 Thread Lennert Buytenhek
gcc4 doesn't allow declaring a static function inside another function, so convert to extern. (The function whose prototype we're changing is not defined anywhere and intended purely to cause a link error when some internal calculations go awry.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED