Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

Maninder Singh writes: > chandef is initialized with NULL and on the very next line, > we are using it to get channel, which is not correct. > > channel should be initialized after obtaining chandef. > > Signed-off-by: Maninder Singh Thanks, applied. -- Kalle Valo -- To unsubscribe from this

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

Maninder Singh writes: >>> chandef is initialized with NULL and on the very next line, >>> we are using it to get channel, which is not correct. >>> >>> channel should be initialized after obtaining chandef. >>> >>> Signed-off-by: Maninder Singh > >>How did you find this bug? > > Static anlysis

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

>> chandef is initialized with NULL and on the very next line, >> we are using it to get channel, which is not correct. >> >> channel should be initialized after obtaining chandef. >> >> Signed-off-by: Maninder Singh >How did you find this bug? Static anlysis reports this bug like coverity or an

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

Maninder Singh writes: > chandef is initialized with NULL and on the very next line, > we are using it to get channel, which is not correct. > > channel should be initialized after obtaining chandef. > > Signed-off-by: Maninder Singh How did you find this bug? -- Kalle Valo -- To unsubscribe

[PATCH 1/1] ath10k: fixing wrong initialization of struct channel

chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(