Re: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-31 Thread Auke Kok
Brandeburg, Jesse wrote: Jeff Garzik wrote: Kok, Auke wrote: Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This doesn't "deprec

RE: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Brandeburg, Jesse
Jeff Garzik wrote: > Kok, Auke wrote: >> Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 >> and ethtool has this functionality in working order. >> >> Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > > This doesn't "deprecated" an

Re: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This doesn't "deprecated" anything, it changes the ABI on a user'

[PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Kok, Auke
Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 69