Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-10 Thread Oliver Hartkopp
On 10.10.20 02:57, Jakub Kicinski wrote: On Wed, 7 Oct 2020 23:31:50 +0200 Marc Kleine-Budde wrote: From: Oliver Hartkopp CAN Transport Protocols offer support for segmented Point-to-Point communication between CAN nodes via two defined CAN Identifiers. As CAN frames can only transport a s

Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-10 Thread Oliver Hartkopp
On 10.10.20 17:44, Jakub Kicinski wrote: On Sat, 10 Oct 2020 16:29:06 +0200 Oliver Hartkopp wrote: diff --git a/net/can/Kconfig b/net/can/Kconfig index 25436a715db3..021fe03a8ed6 100644 --- a/net/can/Kconfig +++ b/net/can/Kconfig @@ -55,6 +55,19 @@ config CAN_GW source "net/can/j1939/K

Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-10 Thread Jakub Kicinski
On Sat, 10 Oct 2020 16:29:06 +0200 Oliver Hartkopp wrote: > >> diff --git a/net/can/Kconfig b/net/can/Kconfig > >> index 25436a715db3..021fe03a8ed6 100644 > >> --- a/net/can/Kconfig > >> +++ b/net/can/Kconfig > >> @@ -55,6 +55,19 @@ config CAN_GW > >> > >> source "net/can/j1939/Kconfig" > >>

Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-10 Thread Jakub Kicinski
On Sat, 10 Oct 2020 18:24:48 +0200 Oliver Hartkopp wrote: > Ok. Understood. > > I'll remove the default=y then. Would it be ok to add some text like > > If you want to perfrom automotive vehicle diagnostic services (UDS), say > 'y'. Most certainly, feel free to provide whatever description you

Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 23:31:50 +0200 Marc Kleine-Budde wrote: > From: Oliver Hartkopp > > CAN Transport Protocols offer support for segmented Point-to-Point > communication between CAN nodes via two defined CAN Identifiers. > As CAN frames can only transport a small amount of data bytes > (max. 8 b

[PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-07 Thread Marc Kleine-Budde
From: Oliver Hartkopp CAN Transport Protocols offer support for segmented Point-to-Point communication between CAN nodes via two defined CAN Identifiers. As CAN frames can only transport a small amount of data bytes (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this segmentation i