Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Joe Perches
On Sun, 2020-11-22 at 00:04 +0100, Marc Kleine-Budde wrote: > On 11/21/20 8:50 PM, Joe Perches wrote: > > > What about moving the default to the end if the case, which is more > > > common anyways: > > > > > > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c > > > b/drivers/net/can/usb/

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Marc Kleine-Budde
On 11/21/20 8:50 PM, Joe Perches wrote: >> What about moving the default to the end if the case, which is more common >> anyways: >> >> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c >> b/drivers/net/can/usb/peak_usb/pcan_usb_core.c > [] >> @@ -295,16 +295,16 @@ static void peak_usb_wr

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 14:17 +0100, Marc Kleine-Budde wrote: > On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > >

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-21 Thread Marc Kleine-Budde
On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gusta

[PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/can/usb/peak_usb/pcan_usb_c