Re: [PATCH 06/11] phy: un-inline devm_mdiobus_register()

2020-06-25 Thread Bartosz Golaszewski
On Tue, Jun 23, 2020 at 1:55 AM Florian Fainelli wrote: > > On 6/22/20 3:00 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Functions should only be static inline if they're very short. This > > devres helper is already over 10 lines and it will grow soon as we'll > > be impr

Re: [PATCH 06/11] phy: un-inline devm_mdiobus_register()

2020-06-22 Thread Florian Fainelli
On 6/22/20 3:00 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Functions should only be static inline if they're very short. This > devres helper is already over 10 lines and it will grow soon as we'll > be improving upon its approach. Pull it into mdio_devres.c. > > Signed-off-b

[PATCH 06/11] phy: un-inline devm_mdiobus_register()

2020-06-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Functions should only be static inline if they're very short. This devres helper is already over 10 lines and it will grow soon as we'll be improving upon its approach. Pull it into mdio_devres.c. Signed-off-by: Bartosz Golaszewski --- drivers/net/phy/Makefile |