Re: [PATCH 05/10] net: ethernet: ixp4xx: Standard module init

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 02:08:19 +0200, Linus Walleij wrote: > @@ -1376,7 +1365,7 @@ static const struct net_device_ops ixp4xx_netdev_ops = { > .ndo_validate_addr = eth_validate_addr, > }; > > -static int eth_init_one(struct platform_device *pdev) > +static int ixp4xx_eth_probe(struct platform

[PATCH 05/10] net: ethernet: ixp4xx: Standard module init

2019-10-20 Thread Linus Walleij
The IXP4xx driver was initializing the MDIO bus before even probing, in the callbacks supposed to be used for setting up the module itself, and with the side effect of trying to register the MDIO bus as soon as this module was loaded or compiled into the kernel whether the device was discovered or