Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Jesse Brandeburg
On Fri, 14 Apr 2006, David S. Miller wrote: > > they are not accounted for in the skb yet. the way e1000 works is it > > pre-allocates all its 128 byte receive buffers using skb_alloc, and then > > chains in any pages that are used for receive packets. > > Ok so you allocate the base skb->dat

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread David S. Miller
From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Fri, 14 Apr 2006 16:04:21 -0700 (Pacific Daylight Time) > On Fri, 14 Apr 2006, David S. Miller wrote: > > > From: Jesse Brandeburg <[EMAIL PROTECTED]> > > Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time) > > > > > Please help me under

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Jesse Brandeburg
On Fri, 14 Apr 2006, David S. Miller wrote: > From: Jesse Brandeburg <[EMAIL PROTECTED]> > Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time) > > > Please help me understand how you think it should work when we have a > > device that wants to receive a packet using header in the skb->

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread David S. Miller
From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time) > Please help me understand how you think it should work when we have a > device that wants to receive a packet using header in the skb->data, and > application data in the ->frags[]? If yo

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Jesse Brandeburg
On Fri, 14 Apr 2006, David S. Miller wrote: > From: Jesse Brandeburg <[EMAIL PROTECTED]> > Date: Fri, 14 Apr 2006 15:13:31 -0700 (Pacific Daylight Time) > > > in the old driver we indicate a packet with truesize = 128, which has 1000 > > bytes of data in it. normally (for everyone using only

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread David S. Miller
From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Fri, 14 Apr 2006 15:13:31 -0700 (Pacific Daylight Time) > in the old driver we indicate a packet with truesize = 128, which has 1000 > bytes of data in it. normally (for everyone using only an skb) skb->len, > and skb->truesize are updated by skb

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Jesse Brandeburg
On Fri, 14 Apr 2006, Jeff Garzik wrote: > Kok, Auke wrote: > > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c > > index 2cc9955..7ba1b16 100644 > > --- a/drivers/net/e1000/e1000_main.c > > +++ b/drivers/net/e1000/e1000_main.c > > @@ -3770,6 +3770,7 @@ e1000_clean_rx_i

Re: [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Jeff Garzik
Kok, Auke wrote: diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 2cc9955..7ba1b16 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -3770,6 +3770,7 @@ e1000_clean_rx_irq_ps(struct e1000_adapt ps_page->ps_

[PATCH 05/10] e1000: Update truesize with the length of the packet for packet split

2006-04-14 Thread Kok, Auke
Update skb with the real packet size. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/driv