Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread Eric W. Biederman
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> writes: > In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 > 20:23:16 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > >> YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> writes: >> >> > Would you explain why it does not work properly >> > for thos

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 20:23:16 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> writes: > > > Would you explain why it does not work properly > > for those cases? > > Mostly no appropriate strategy routine was setup

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread Eric W. Biederman
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> writes: > Would you explain why it does not work properly > for those cases? Mostly no appropriate strategy routine was setup to report the data to the caller of sys_sysctl. Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary > sysctl names for a function that works with proc. : Well, retrans_time_ms and base_reachable_time_ms superc

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > But it is good to remove bad interfaces, if we possibly can. > > It is worth making the attempt. Does anyone know of anything which will > break? I fed NET_NEIGH_ANYCAST_DELAY at random into > http://www.google.com/codesearch and came up with nothing..

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:49:21 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 10 Aug 2007 10:47:10 +0900 (JST) > > > I disagree. It is bad to remove existing interface. > > Ditto for other patc

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread Andrew Morton
On Fri, 10 Aug 2007 10:47:10 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > Hello. > > In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL > PROTECTED] (Eric W. Biederman) says: > > > > > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on bi

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 10:47:10 +0900 (JST) > I disagree. It is bad to remove existing interface. > Ditto for other patches. I think perhaps you misunderstand what Eric is doing. sys_sysctl() isn't working properly for these cases and it is bot

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary > sysctl names for a function that works with proc. > > - In neighbour.c reorder the table to put the

[PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread Eric W. Biederman
- In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary sysctl names for a function that works with proc. - In neighbour.c reorder the table to put the possibly unused entries at the end so we can remove them by terminating the table early. - In neighbour.c kill the entries with q