Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Saeed Mahameed
On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > This cleans up a lot of unneeded code and l

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread gre...@linuxfoundation.org
On Tue, Aug 06, 2019 at 07:41:57PM +, Saeed Mahameed wrote: > On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic > > should > > never do something

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Saeed Mahameed
On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > This cleans up a lot of unneeded code and l

[PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier